feat(hierarchical-menu): persist refined root level count with a future flag #5950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c9ce3e8:
|
dhayab
requested review from
a team,
sarahdayan and
aymeric-giraudet
and removed request for
a team
Haroenv
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The current design of hierarchical facets in InstantSearch is to show the count of the active refined parent level next to its root level. This is not necessarily what current users of InstantSearch expect, so this PR provides an option in the form a future flag, to allow them to switch to a new behaviour where the root level count is not modified in answer to refinement changes.
Result
Users can now choose whether they want a hierarchical facet parent count reflected in the root level, or leave the root count untouched.
FX-2671