Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue): avoid passing a proxied object in Configure #6166

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

aymeric-giraudet
Copy link
Member

@aymeric-giraudet aymeric-giraudet commented Apr 26, 2024

Summary

Fixes #6163
Fixes #6164

Result

Added a test that was failing in Vue3, it works now !

@aymeric-giraudet aymeric-giraudet requested review from a team, dhayab, sarahdayan and Haroenv and removed request for a team April 26, 2024 08:35
Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com>
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 966b9ed:

Sandbox Source
example-instantsearch-getting-started Configuration
example-react-instantsearch-getting-started Configuration
example-react-instantsearch-next-app-dir-example Configuration
example-react-instantsearch-next-routing-example Configuration
example-vue-instantsearch-getting-started Configuration

@tkjaergaard
Copy link

💪

@Haroenv Haroenv merged commit 93cfd60 into master Apr 26, 2024
12 checks passed
@Haroenv Haroenv deleted the fix/vue-configure-params-proxy branch April 26, 2024 11:01
@nickycdk
Copy link

@Haroenv - Doesn't seem like there are any new releases to the "vue-instantsearch" package?

@Haroenv
Copy link
Contributor

Haroenv commented Apr 26, 2024

No, it's Friday. This will be released later

@ashotmark
Copy link

ashotmark commented Apr 29, 2024

@Haroenv we faced same issue, and I see that this is not published yet.
Our project is waiting until this will be published into npm. it would be appreciated that publish happens asap.
could you please let us know when this will be published?

@dhayab
Copy link
Member

dhayab commented Apr 30, 2024

Hi, we just released vue-instantsearch@4.16.1 which includes a fix for this issue.

@ashotmark
Copy link

sounds good, thanks! let me upgrade now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants