fix(hits): rename the exposed "hits" to "items" #6212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`hits` of course still works for now, but `items` is also available from the connectors. A warning on getting of `hits` from the connector is given, which does not fire on normal usage of the components. For now, no change is done in `ui-components`, but I'm happy to do so if we're happy with the hypothetical breaking change for that package.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0cb7190:
|
Haroenv
requested review from
a team,
dhayab and
aymeric-giraudet
and removed request for
a team
dhayab
approved these changes
May 31, 2024
|
not that I saw @dhayab |
aymeric-giraudet
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace the exposed
hitswithitemsfor consistency with recommend, transformItems and other widgets that all returnitems.hitsof course still works for now, butitemsis also available from the connectors.Result
As well as
hits,itemsis also available from connectHits, connectInfiniteHits (connectGeoSearch already only haditems)There's no warning for using
hits, as there's no way to have that in a way which doesn't warn for regular usage too.For now, no change is done in
ui-components, but I'm happy to do so if we're happy with the hypothetical breaking change for that package.