Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

Places overwrites Promise in Firefox! Probably because of @babel/polyfill? #725

Closed
pmochine opened this issue Feb 4, 2019 · 3 comments
Closed
Assignees
Labels

Comments

@pmochine
Copy link

pmochine commented Feb 4, 2019

I opend the question in Stackoverflow. Please have a detailed look here.

But to make it short, I noticed an error in Firefox:

TypeError: Promise.resolve(...).finally is not a function[Learn More]

I found out that import places from 'places.js'; overwrites the native promise.

If you try this out, it should work on firefox

 Promise.resolve(42).finally(() => console.log('jo'));

but it does not! Test it on your own demo page: https://community.algolia.com/places/

Please add finally to promise or my other guess is in package.json

 @babel/polyfill": "^7.2.5" <-- it's in dependencies (does it need to be there?)
@JonathanMontane
Copy link
Contributor

Thanks for the report.
I have a fix pending for this issue in #726

@pmochine
Copy link
Author

pmochine commented Feb 5, 2019

Thanks @JonathanMontane <3

@pmochine pmochine closed this as completed Feb 5, 2019
@JonathanMontane
Copy link
Contributor

It's being released. You should be able to update your package version to 1.15.5 anytime soon.
Thanks for the report 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants