fix: Prevent infinite loop with React 16 refs

[skvale]

Relates to #344

This provides a reproduction of the bug with a test.

Remove this block

 if (key === 'current') {
        // eslint-disable-next-line no-param-reassign
        result[key] = '[Circular]';
 }

and it will fail with the Maximum call stack size exceeded going into the circular

element->ref->current->element->ref->current

loop.

[vvo]

Hey there, thanks, I was trying to fix your tests, and thought that it was because of incompat issues with latest nodejs, so I created: #358

but then there's another test error we have seen in the past already (#340) cc @Spy-Seth à l'aide :D (help us)

[armandabric]

😭😭😭😭

I will not be able to have a look this week 😢

[armandabric]

Fixing #358 and rebasing this PR make it green.

Not sure this is a good thing: it means our code try to write on read only object attributes sometimes and node v12 now trigger error on CI (not on my laptop...). We should investigate this

[hipstersmoothie]

any progress on this?

Edit: I've tested in my storybook and the change fixes the issue

[vvo]

I see this code is now working on Node v12 so we're good to go

[vvo]

released as 14.0.3