-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: accept multiple objectID
s
#8
Conversation
This updates the API to accept multiple `objectID`s as references to get recommendations from. In the context of a shopping cart, getting recommendations based on all items is a common pattern.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to sort before deduping so that the lowest scored version of the item gets removed?
If it's possible to have 2 recommend score for the same objectID, yes
@shortcuts I noted it on my board—I'll take care of deduping correctly in another PR along with some tests. |
Description
In the context of a shopping cart, getting recommendations based on all items is a common pattern. This updates the API to accept multiple
objectID
s as references to get recommendations from.How it works
objectIDs
viasearchClient.getObjects
, with ahitsPerPage
value divided by the number ofobjectIDs
objectID
s, so we remove any duplications.objectIDs
in a continuous wayQuestions