This repository was archived by the owner on Dec 30, 2022. It is now read-only.
feat(CurrentRefinements): give createURL to slot #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function is prefilled this with the item. I'm doubting if maybe it should be prefilled with the url in the `item` itself instead? This is a larger change and we can do it another time though
samouss
suggested changes
Oct 30, 2018
|
Will do |
Haroenv
added a commit
to algolia/instantsearch
that referenced
this pull request
Dec 28, 2022
…search#557) * feat(CurrentRefinements): give createURL to slot The function is prefilled this with the item. I'm doubting if maybe it should be prefilled with the url in the `item` itself instead? This is a larger change and we can do it another time though * test: make sure all things are visible as usual
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function is prefilled this with the item.
I'm doubting if maybe it should be prefilled with the url in the
itemitself instead? This is a larger change and we can do it another time though