Skip to content
This repository has been archived by the owner on Dec 30, 2022. It is now read-only.

feat(RangeInput): refine & currentRefinement sync #560

Merged
merged 3 commits into from
Nov 2, 2018
Merged

Conversation

Haroenv
Copy link
Contributor

@Haroenv Haroenv commented Nov 1, 2018

  1. currentRefinements -> currentRefinement
  2. currentRefinement: object
  3. refine: object

The tests aren't changed; since the internal refine is tested, not the exposed one

IFW-196

1. currentRefinements -> currentRefinement
2. currentRefinement: object
3. refine: object
@Haroenv Haroenv requested a review from samouss November 1, 2018 14:47
docs/src/components/RangeInput.md Outdated Show resolved Hide resolved
@samouss
Copy link
Contributor

samouss commented Nov 1, 2018

You can still add a test for the slot that will assert that the exposed API is the expected one (this is what we do in the stories, agree but better safe than sorry).

francoischalifour and others added 2 commits November 2, 2018 09:28
Co-Authored-By: Haroenv <fingebimus@me.com>
Co-Authored-By: Haroenv <fingebimus@me.com>
@Haroenv Haroenv merged commit 433e88b into v2 Nov 2, 2018
@Haroenv Haroenv deleted the feat/range-refine branch November 2, 2018 08:29
Haroenv added a commit to algolia/instantsearch that referenced this pull request Dec 28, 2022
…tsearch#560)

* feat(RangeInput): refine & currentRefinement sync

1. currentRefinements -> currentRefinement
2. currentRefinement: object
3. refine: object

* Update src/components/RangeInput.vue

Co-Authored-By: Haroenv <fingebimus@me.com>

* Update docs/src/components/RangeInput.md

Co-Authored-By: Haroenv <fingebimus@me.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants