This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
feat(router): force object form #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkrugg
reviewed
Nov 2, 2018
tkrugg
reviewed
Nov 2, 2018
Co-Authored-By: Haroenv <fingebimus@me.com>
tkrugg
reviewed
Nov 2, 2018
tkrugg
approved these changes
Nov 2, 2018
Haroenv
added a commit
to algolia/instantsearch
that referenced
this pull request
Dec 28, 2022
* docs(routing): document full version of IS router, not shorthand in guide * docs(routing): only document object form * feat(router): force object form * docs(examples): use object form * fix(InstantSearch): no unreachable code * docs: split up in bullets Co-Authored-By: Haroenv <fingebimus@me.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IFW-221
We force the object form, because that way there's less options, using it as a widget would indeed be nicer than as option, but we can do that later, I didn't completely grasp how to do that with InstantSearch.js, it seems to be setting some internal things, more than just a widget