This repository was archived by the owner on Dec 30, 2022. It is now read-only.
fix(RefinementList): allow overriding of searchable placeholder #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also noticed that the test was broken for `searchable`, so fixed that one too. New prop: placeholder on `RefinementList` fixes #572
samouss
reviewed
Nov 12, 2018
| @@ -25,6 +25,7 @@ Name | Type | Default | Description | Required | |||
| ---|---|---|---|--- | |||
| attribute | string | | The attribute to refine on click | yes | |||
| searchable | boolean | `false` | You can also search within the options of this | no | |||
| placeholder | string | "Search here …" | If searchable is `true`, this will be the placeholder for that search box | no | |||
There was a problem hiding this comment.
Placeholder is a bit broad in the context of a RefinementList. Why not searchablePlaceholder ?
There was a problem hiding this comment.
We indeed call this searchablePlaceholder in InstantSearch.js 3 (see new options).
| @@ -121,6 +124,11 @@ export default { | |||
| type: Boolean, | |||
| default: false, | |||
| }, | |||
| searchablePlaceholder: { | |||
| default: 'Search here…', | |||
There was a problem hiding this comment.
This is not part of the RefinementList spec yet, I'm not sure we want a default placeholder here?
In InstantSearch.js 3 it's "Search..." for now but I would rather go without any.
There was a problem hiding this comment.
there will always be a placeholder since we use ais-search-box, we should probably spec it
also, go back to rest 👨⚕️
Haroenv
added a commit
to algolia/instantsearch
that referenced
this pull request
Dec 28, 2022
…lia/vue-instantsearch#576) * fix(RefinementList): allow overriding of searchable placeholder Also noticed that the test was broken for `searchable`, so fixed that one too. New prop: placeholder on `RefinementList` fixes algolia/vue-instantsearch#572 * Update RefinementList.md * chore: searchablePlaceholder
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also noticed that the test was broken for
searchable, so fixed that one too.New prop:
searchable-placeholderonais-refinement-listfixes #572