This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
fix(components): remove faulty whitespace #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an inline element has whitespace, and then a text node, Vue will preserve this whitespace inside the component, and thus it will take up bundle size (a tiny little bit)
Haroenv
commented
Jan 17, 2019
There was a problem hiding this comment.
In InstantSearch.js, we compress the templates to avoid creating unnecessary text nodes (algolia/instantsearch#3176). This allows to keep our templates more readable.
In React, we don't have this issue because JSX ignores whitespaces. Is there any way to achieve that with Vue?
|
I've looked and no automatic way exists to do these changes |
|
I came across this thread but it might be too complex for now. |
francoischalifour
approved these changes
Jan 17, 2019
|
I would have prefer to use the |
|
We are not using the |
|
We do through the Rollup plugin. |
Haroenv
added a commit
that referenced
this pull request
Jan 18, 2019
* fix(components): remove faulty whitespace If an inline element has whitespace, and then a text node, Vue will preserve this whitespace inside the component, and thus it will take up bundle size (a tiny little bit) * chore(error): no newline * chore(error): https
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an inline element has whitespace, and then a text node, Vue will preserve this whitespace inside the component, and thus it will take up bundle size (a tiny little bit)