This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 157
fix(umd): prevent inclusion of Vue in bundle #635
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This warning appears while building.
|
good call, I didn't have it earlier, but can replicate now @francoischalifour |
by the way, nice effect of this: before
after
|
Nice decrease! |
samouss
suggested changes
Mar 6, 2019
It's better without Vue embed! |
samouss
approved these changes
Mar 7, 2019
Haroenv
added a commit
to algolia/instantsearch
that referenced
this pull request
Dec 28, 2022
…ch#635) * fix(umd): do not bundle Vue * fix(umd): use Vue instance of provided component * fix(umd): make import clearer * fix(rollup): specify which global Vue uses * refactor(plugin): clearer naming
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fixed in two spots:
Furthermore this also fixes the plugin which needlessly exposes all widgets (you can already import them easily, since the default export is being put on the window)