This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
feat(voiceSearch): add voice search component #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should've made this a draft pr since this cannot be merged at the moment because we need to wait for IS.js to be published. |
Haroenv
reviewed
May 8, 2019
Haroenv
reviewed
May 9, 2019
Haroenv
reviewed
May 14, 2019
ghost
requested review from
Co-Authored-By: Haroen Viaene <fingebimus@me.com>
Haroenv
approved these changes
May 14, 2019
|
Let's wait until 3.5.1 is published. |
added 2 commits
May 20, 2019 15:16
…rch into feat/voice-search
|
@Haroenv re-requesting a final review before merge. |
Haroenv
approved these changes
May 21, 2019
Haroenv
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Dec 28, 2022
…rch#668) * chore(voiceSearch): scope styles to non-ais elements * feat(voiceSearch): WIP adding voiceSearch component * test(voiceSearch): add stories * test(voiceSearch): add tests for the component * chore(voiceSearch): formatted * chore(voiceSearch): fix lint errors * doc: revert a mistake * chore(voiceSearch): remove unnecessary computed properties * feat(voiceSearch): provide all data to the default root slot * feat(voiceSearch): change slot properties to kebab case * feat(voiceSearch): add a computed property for root slot props * chore(voiceSearch): replace temp files with the ones from latest IS.js * fix(voiceSearch): fix an import path * chore(voiceSearch): update bundlesize * Apply suggestions from code review Co-Authored-By: Haroen Viaene <fingebimus@me.com> * chore: update IS.js@3.5.1 * chore: update bundlesize
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds a new voice search component.
Checklist
tmp/with the ones from published IS.js