fix(highlight): change expected tag to replace

[Haroenv]

fixes #639

to fully fix #639, we also want algolia/instantsearch#3830 to be merged, however those are completely separate issues

[Haroenv]

I checked it, and this change also fixes it for searchable

[francoischalifour]

The stories don't seem to work, they display <mark>Text</mark>.

[Haroenv]

That’s because of InstantSearch’s PR not yet been used here (there’s two hits widgets). You can check a story with only one hits to see it working compared to previously.

[samouss]

Now that InstantSearch 3.x.x is available we should be able to use highlight & snippet that are available on the default export. We don't have to duplicate the logic to perform this operation.

innerHTML() {
  return instantsearch.highlight({
    attribute: this.attribute,
    hit: this.hit,
    highlightedTagName: this.highlightedTagName,
  });
},

[Haroenv]

That’ll only work with escapeHTML: false, which is why I didn’t go for it

[samouss]

You're sure? I've tested it without issues. We use the same strategy inside InstantSearch.js.

[Haroenv]

It's possible that it works, but in the end it would be best if we migrate the InstantSearch highlight strategy to the one of React InstantSearch where there's no need for escaping or innerHTML, but you can map over the parts

[benjam-es]

highlighted-tag-name still does not work for me. Is the above fix tagged?

I'm on "vue-instantsearch": "^2.2.1"

[francoischalifour]

@benjam-es The issue is fully fixed since #691 which updates the InstantSearch.js dependency. Vue InstantSearch wasn't released since. The highlighted-tag-name behavior will work as expected in the next version.