This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
fix(ssr): clearer error message when using ssr without the component #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #697 We are patching the InstantSearch instance in SSR, but you could be using the code for SSR without using the patched InstantSearch instance. The error being thrown then is confusing, since it just complains about a missing property. We have no differential error management with short & long error messages in prod/dev here yet, so I tried to be between both (not too long)
ghost
requested review from
francoischalifour and
yannickcr
and removed request for
a team
francoischalifour
approved these changes
Jul 22, 2019
samouss
reviewed
Jul 22, 2019
Haroenv
added a commit
to algolia/instantsearch
that referenced
this pull request
Dec 28, 2022
…lgolia/vue-instantsearch#698) fixes algolia/vue-instantsearch#697 We are patching the InstantSearch instance in SSR, but you could be using the code for SSR without using the patched InstantSearch instance. The error being thrown then is confusing, since it just complains about a missing property. We have no differential error management with short & long error messages in prod/dev here yet, so I tried to be between both (not too long)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #697
We are patching the InstantSearch instance in SSR, but you could be using the code for SSR without using the patched InstantSearch instance.
The error being thrown then is confusing, since it just complains about a missing property.
We have no differential error management with short & long error messages in prod/dev here yet, so I tried to be between both (not too long), this still has a .03kb difference in the bundle, so I updated the limits