This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
feat(ssr): forward propsData to recreated component #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haroenv
force-pushed
the
fix/vue-vuex-ssr
branch
from
16ffcce to
8bfd878
Compare
TODO: this throws a warning (but works) because of: https://github.com/vuejs/vue/blob/7912f75c5eb09e0aef3e4bfd8a3bb78cad7540d7/src/core/util/options.js#L34-L44 I'm not fully sure how to do `new Vue` or pass this parameter correctly. If I `Object.assign` it for `app = new Vue({...extended, propsData})`, it also doesn't work :/
Haroenv
force-pushed
the
fix/vue-props-ssr
branch
from
7d9b64b to
dca2d01
Compare
Haroenv
added a commit
to algolia/instantsearch
that referenced
this pull request
Dec 28, 2022
…antsearch#865) * feat(ssr): forward propsData to recreated component TODO: this throws a warning (but works) because of: https://github.com/vuejs/vue/blob/7912f75c5eb09e0aef3e4bfd8a3bb78cad7540d7/src/core/util/options.js#L34-L44 I'm not fully sure how to do `new Vue` or pass this parameter correctly. If I `Object.assign` it for `app = new Vue({...extended, propsData})`, it also doesn't work :/ * fix co-authored-by: Eunjae Lee <eunjae-lee@users.noreply.github.com> Co-authored-by: Eunjae Lee <eunjae-lee@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
propsData isn't valid as argument to
.extend, but you don't need to callnew Vue(comp), it's the same as callingnew comp({propsData...})