CI: add dupword linter and fix issues (#6474)

Co-authored-by: John Jannotti <jannotti@gmail.com>

Author: cce

.github/workflows/reviewdog.yml

@@ -1,6 +1,6 @@
 name: "ReviewDog workflow"
 env:
-  GOLANGCI_LINT_VERSION: "v2.5.0"
+  GOLANGCI_LINT_VERSION: "v2.5.1-0.20251021235302-b99da877a247"
 on:
   push:
     branches:
@@ -23,17 +23,39 @@ jobs:
       # move go out of the way temporarily to avoid "go list ./..." from installing modules
       - name: Make libsodium.a
         run: sudo mv /usr/bin/go /usr/bin/go.bak && make libsodium && sudo mv /usr/bin/go.bak /usr/bin/go
-      - name: reviewdog-golangci-lint
-        uses: reviewdog/action-golangci-lint@v2.8.0
-        with:
-          go_version_file: go.mod
-          golangci_lint_version: ${{ env.GOLANGCI_LINT_VERSION }}
-          golangci_lint_flags: "-c .golangci.yml --allow-parallel-runners"
-          reporter: "github-pr-check"
-          tool_name: "Lint Errors"
-          level: "error"
-          fail_level: any
-          filter_mode: "nofilter"
+      - name: Add bin to PATH
+        run: |
+          echo "$GITHUB_WORKSPACE/bin" >> $GITHUB_PATH
+          echo "$RUNNER_WORKSPACE/$(basename $GITHUB_REPOSITORY)/bin" >> $GITHUB_PATH
+      - name: Set up Go
+        uses: ./.github/actions/setup-go
+      - name: Install golangci-lint
+        run: |
+          go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@${{ env.GOLANGCI_LINT_VERSION }}
+          golangci-lint --version
+      - name: Install reviewdog
+        run: |
+          curl -sfL https://raw.githubusercontent.com/reviewdog/reviewdog/v0.21.0/install.sh | sh -s -- v0.21.0
+          reviewdog --version
+      - name: Run golangci-lint with reviewdog
+        env:
+          REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          set -e
+
+          golangci-lint run \
+          --output.text.path stdout \
+          -c .golangci.yml \
+          --issues-exit-code 0 \
+          --allow-parallel-runners > temp_golangci-lint-errors.txt
+
+          cat temp_golangci-lint-errors.txt | reviewdog \
+          -f=golangci-lint \
+          -name="Lint Errors" \
+          -reporter=github-pr-check \
+          -filter-mode=nofilter \
+          -fail-level=any \
+          -level=error
   # Non-Blocking Warnings Section
   reviewdog-warnings:
     runs-on: ubuntu-latest

.golangci.yml

@@ -6,6 +6,7 @@ linters:
   default: none
   enable:
     - copyloopvar
+    - dupword
     - errcheck
     - govet
     - ineffassign
@@ -18,6 +19,10 @@ linters:
     - unused
 
   settings:
+    dupword:
+      comments-only: true
+      ignore:
+        - long # "long long" is OK
     errcheck:
       exclude-functions:
         # We do this 121 times and never check the error.
@@ -28,6 +33,8 @@ linters:
       # Enables these linters in addition to the default ones.
       enable:
         - shadow
+      disable:
+        - buildtag
       settings:
         printf:
           # Comma-separated list of print function names to check (in addition to default, see `go tool vet help printf`).
@@ -89,7 +96,6 @@ linters:
         linters:
           - errcheck
           - ineffassign
-          - misspell
           - nolintlint
           - staticcheck
           - unused

agreement/state_machine_test.go

@@ -391,7 +391,7 @@ func (blackhole) Write(data []byte) (int, error) {
 	return len(data), nil
 }
 
-// deterministicTraceTestCase encapsulates a traditional unit test test case.
+// deterministicTraceTestCase encapsulates a traditional unit test case.
 type determisticTraceTestCase struct {
 	inputs          []event
 	expectedOutputs []event

catchup/service_test.go

@@ -1088,7 +1088,7 @@ func TestServiceLedgerUnavailable(t *testing.T) {
 	require.Less(t, local.LastRound(), remote.LastRound())
 }
 
-// TestServiceNoBlockForRound checks if fetchAndWrite does not repeats 500 times if a block not avaialble
+// TestServiceNoBlockForRound checks if fetchAndWrite does not repeats 500 times if a block not available
 func TestServiceNoBlockForRound(t *testing.T) {
 	partitiontest.PartitionTest(t)
 

config/localTemplate.go

@@ -326,7 +326,7 @@ type Local struct {
 	// determining the source of a connection.  If used, it should be set to the string "X-Forwarded-For", unless the
 	// proxy vendor provides another header field.  In the case of CloudFlare proxy, the "CF-Connecting-IP" header
 	// field can be used.
-	// This setting does not support multiple X-Forwarded-For HTTP headers or multiple values in in the header and always uses the last value
+	// This setting does not support multiple X-Forwarded-For HTTP headers or multiple values in the header and always uses the last value
 	// from the last X-Forwarded-For HTTP header that corresponds to a single reverse proxy (even if it received the request from another reverse proxy or adversary node).
 	//
 	// WARNING: By enabling this option, you are trusting peers to provide accurate forwarding addresses.

crypto/merklearray/merkle_test.go

@@ -485,7 +485,7 @@ func TestSizeLimitsMerkle(t *testing.T) {
 	for depth := uint64(0); depth < uint64(18); depth = depth + increment {
 		size := uint64(1) << depth
 
-		// eltCoefficient is the coefficent to determine how many elements are in the proof.
+		// eltCoefficient is the coefficient to determine how many elements are in the proof.
 		// There will be 1/eltCoefficient elements of all possible element (2^treeDepth)
 		// numElts = 2^(depth-eltCoefficient)
 

crypto/multisig_test.go

@@ -310,7 +310,7 @@ func TestMoreThanMaxSigsInMultisig(t *testing.T) {
 	}
 
 	msig, err := MultisigAssemble(sigs)
-	require.NoError(t, err, "Multisig: error assmeble multisig")
+	require.NoError(t, err, "Multisig: error assemble multisig")
 	err = MultisigVerify(txid, addr, msig)
 	require.Error(t, err, "Multisig: did not return error as expected")
 	br := MakeBatchVerifier()
@@ -346,7 +346,7 @@ func TestOneSignatureIsEmpty(t *testing.T) {
 	}
 
 	msig, err := MultisigAssemble(sigs)
-	require.NoError(t, err, "Multisig: error assmeble multisig")
+	require.NoError(t, err, "Multisig: error assemble multisig")
 	msig.Subsigs[0].Sig = Signature{}
 	err = MultisigVerify(txid, addr, msig)
 	require.Error(t, err, "Multisig: did not return error as expected")
@@ -386,7 +386,7 @@ func TestOneSignatureIsInvalid(t *testing.T) {
 
 	sigs[1].Subsigs[1].Sig[5] = sigs[1].Subsigs[1].Sig[5] + 1
 	msig, err := MultisigAssemble(sigs)
-	require.NoError(t, err, "Multisig: error assmeble multisig")
+	require.NoError(t, err, "Multisig: error assemble multisig")
 	err = MultisigVerify(txid, addr, msig)
 	require.Error(t, err, "Multisig: did not return error as expected")
 	br := MakeBatchVerifier()

daemon/algod/api/server/v1/routes/routes.go

@@ -22,7 +22,7 @@ import (
 )
 
 // V1Routes contains all routes for v1
-// v1 algod paths will route to the sunset message, resulting in a 410 Gone response.
+// These algod paths will route to the sunset message, resulting in a 410 Gone response.
 var V1Routes = lib.Routes{
 	lib.Route{
 		Name:        "status",

daemon/kmd/api/v1/handlers.go

@@ -38,7 +38,7 @@ type reqContext struct {
 	sm *session.Manager
 }
 
-// errorResponse sets the specified status code (should != 200), and fills in the
+// errorResponse sets the specified status code (should != 200), and fills in
 // the response envelope by setting Error to true and a Message to the passed
 // user-readable error message.
 func errorResponse(w http.ResponseWriter, status int, err error) {

daemon/kmd/config/config.go

@@ -104,7 +104,7 @@ func (k KMDConfig) Validate() error {
 	return nil
 }
 
-// LoadKMDConfig tries to read the the kmd configuration from disk, merging the
+// LoadKMDConfig tries to read the kmd configuration from disk, merging the
 // default kmd configuration with what it finds
 func LoadKMDConfig(dataDir string) (cfg KMDConfig, err error) {
 	cfg = defaultConfig(dataDir)