tests: remove "Fail" part from test test names (#6377)

Author: algorandskiy

agreement/cryptoVerifier_test.go

@@ -388,9 +388,9 @@ func BenchmarkCryptoVerifierBundleVertification(b *testing.B) {
 	}
 }
 
-// TestCryptoVerifierVerificationFailures tests to see that the cryptoVerifier.VerifyVote returns an error in the vote response
+// TestCryptoVerifierVerificationErrs tests to see that the cryptoVerifier.VerifyVote returns an error in the vote response
 // when being unable to enqueue a vote.
-func TestCryptoVerifierVerificationFailures(t *testing.T) {
+func TestCryptoVerifierVerificationErrs(t *testing.T) {
 	partitiontest.PartitionTest(t)
 
 	mainPool := execpool.MakePool(t)

agreement/persistence_test.go

@@ -278,7 +278,7 @@ func TestEmptyMapDeserialization(t *testing.T) {
 	require.NotNil(t, v1.Equivocators)
 }
 
-func TestDecodeFailures(t *testing.T) {
+func TestDecodeErrs(t *testing.T) {
 	partitiontest.PartitionTest(t)
 	clock := timers.MakeMonotonicClock[TimeoutType](time.Date(2015, 1, 2, 5, 6, 7, 8, time.UTC))
 	ce := clock.Encode()

agreement/pseudonode_test.go

@@ -458,22 +458,22 @@ func TestPseudonodeLoadingOfParticipationKeys(t *testing.T) {
 
 type substrServiceLogger struct {
 	logging.Logger
-	looupStrings   []string
+	lookupStrings  []string
 	instancesFound []int
 }
 
 func (ssl *substrServiceLogger) Infof(s string, args ...interface{}) {
-	for i, str := range ssl.looupStrings {
+	for i, str := range ssl.lookupStrings {
 		if strings.Contains(s, str) {
 			ssl.instancesFound[i]++
 			return
 		}
 	}
 }
 
-// TestPseudonodeFailedEnqueuedTasks test to see that in the case where we cannot enqueue the verification task to the backlog, we won't be waiting forever - instead,
+// TestPseudonodeNonEnqueuedTasks test to see that in the case where we cannot enqueue the verification task to the backlog, we won't be waiting forever - instead,
 // we would generate a warning message and keep going.
-func TestPseudonodeFailedEnqueuedTasks(t *testing.T) {
+func TestPseudonodeNonEnqueuedTasks(t *testing.T) {
 	partitiontest.PartitionTest(t)
 
 	t.Parallel()
@@ -485,7 +485,7 @@ func TestPseudonodeFailedEnqueuedTasks(t *testing.T) {
 
 	subStrLogger := &substrServiceLogger{
 		Logger:         logging.TestingLog(t),
-		looupStrings:   []string{"pseudonode.makeVotes: failed to enqueue vote verification for", "pseudonode.makeProposals: failed to enqueue vote verification"},
+		lookupStrings:  []string{"pseudonode.makeVotes: failed to enqueue vote verification for", "pseudonode.makeProposals: failed to enqueue vote verification"},
 		instancesFound: []int{0, 0},
 	}
 	sLogger := serviceLogger{

catchup/peerSelector_test.go

@@ -325,7 +325,7 @@ func peerSelectorTestRandVal(t *testing.T, seed int) float64 {
 	randVal = randVal + 1
 	return randVal
 }
-func TestPeerSelector_PeersDownloadFailed(t *testing.T) {
+func TestPeerSelector_PeersDownloadError(t *testing.T) {
 	partitiontest.PartitionTest(t)
 	t.Parallel()
 

config/config_test.go

@@ -915,7 +915,7 @@ func TestEnsureAndResolveGenesisDirs_migrate(t *testing.T) {
 	require.FileExists(t, filepath.Join(hotDir, "stateproof.sqlite-wal"))
 }
 
-func TestEnsureAndResolveGenesisDirs_migrateCrashFail(t *testing.T) {
+func TestEnsureAndResolveGenesisDirs_migrateCrashErr(t *testing.T) {
 	partitiontest.PartitionTest(t)
 
 	cfg := GetDefaultLocal()
@@ -947,7 +947,7 @@ func TestEnsureAndResolveGenesisDirs_migrateCrashFail(t *testing.T) {
 	require.NoFileExists(t, filepath.Join(hotDir, "crash.sqlite-shm"))
 }
 
-func TestEnsureAndResolveGenesisDirs_migrateSPFail(t *testing.T) {
+func TestEnsureAndResolveGenesisDirs_migrateSPErr(t *testing.T) {
 	partitiontest.PartitionTest(t)
 
 	cfg := GetDefaultLocal()

daemon/algod/api/server/v2/test/handlers_test.go

@@ -1285,7 +1285,7 @@ int 1`,
 	}
 }
 
-func TestSimulateTransactionVerificationFailure(t *testing.T) {
+func TestSimulateTransactionVerificationErr(t *testing.T) {
 	partitiontest.PartitionTest(t)
 	t.Parallel()
 

data/bookkeeping/block_test.go

@@ -562,7 +562,7 @@ func TestInitialRewardsRateCalculation(t *testing.T) {
 		return true
 	}
 
-	// test expected failuire
+	// test expected failure
 	consensusParams.InitialRewardsRateCalculation = false
 	require.False(t, runTest())
 
@@ -658,7 +658,7 @@ func TestNextRewardsRateWithFix(t *testing.T) {
 	}
 }
 
-func TestNextRewardsRateFailsWithoutFix(t *testing.T) {
+func TestNextRewardsRateErrsWithoutFix(t *testing.T) {
 	partitiontest.PartitionTest(t)
 	t.Parallel()
 

data/transactions/logic/evalAppTxn_test.go

@@ -1379,7 +1379,7 @@ int 1
 	})
 }
 
-func TestCreateOldAppFails(t *testing.T) {
+func TestCreateOldAppErrs(t *testing.T) {
 	partitiontest.PartitionTest(t)
 	t.Parallel()
 

data/transactions/logic/eval_test.go

@@ -4590,7 +4590,7 @@ func TestLinearOpcodes(t *testing.T) {
 	}
 }
 
-func TestRekeyFailsOnOldVersion(t *testing.T) {
+func TestRekeyErrsOnOldVersion(t *testing.T) {
 	partitiontest.PartitionTest(t)
 	t.Parallel()
 

data/transactions/verify/txn_test.go

@@ -932,9 +932,9 @@ func TestTxnHeartbeat(t *testing.T) {
 	verifyGroup(t, txnGroups, &blkHdr, breakHbProofFunc, restoreHbProofFunc, crypto.ErrBatchHasFailedSigs.Error())
 }
 
-// TestTxnGroupCacheUpdateFailLogic test makes sure that a payment transaction contains a logic (and no signature)
+// TestTxnGroupCacheUpdateRejLogic test makes sure that a payment transaction contains a logic (and no signature)
 // is valid (and added to the cache) only if logic passes
-func TestTxnGroupCacheUpdateFailLogic(t *testing.T) {
+func TestTxnGroupCacheUpdateRejLogic(t *testing.T) {
 	partitiontest.PartitionTest(t)
 
 	_, signedTxn, _, _ := generateTestObjects(100, 20, 0, 50)