Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catchup regression after p2p merge due to rate limiting #6117

Closed
onetechnical opened this issue Aug 29, 2024 · 0 comments · Fixed by #6118
Closed

Catchup regression after p2p merge due to rate limiting #6117

onetechnical opened this issue Aug 29, 2024 · 0 comments · Fixed by #6118
Assignees
Labels
bug Something isn't working

Comments

@onetechnical
Copy link
Contributor

onetechnical commented Aug 29, 2024

Subject of the issue

Requests for blocks in normal catchup are triggering rate limiting. This results in slow catchup performance and repeated pauses.

Note that this behavior starts with the p2p merge c8407abc #5939. A binary built from the immediately preceding commit 63c0d5bd does not have this problem.

Your environment

  • Software version: 3.26.2066.nightly [rel/nightly] (commit #9364f13b)
  • In this particular case, running on DevNet
  • Replicated on both Ubuntu and Darwin

Steps to reproduce

  1. Get the latest nightly binary
  2. Start the node

Expected behaviour

Fast, progressive catchup.

Actual behaviour

  • Ledger will advance a couple hundred blocks
  • Ledger will stop advancing for about 18s
  • Repeat

This is due to rate limiting, as the logs will report 429 errors, e.g.:

HTTPFetcher.getBlockBytes: response status code 429 from '/v1/devnet-v1.0/block/ilk0f'. Response body '' 

On the server side this will be reported as "Remote IP Connection Rate Limit".

@onetechnical onetechnical added the bug Something isn't working label Aug 29, 2024
@onetechnical onetechnical changed the title Catchup regression in p2p behavior due to rate limiting Catchup regression after p2p merge due to rate limiting Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants