Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad error message when passing transaction as ABI method argument #781

Closed
acfunk opened this issue May 11, 2023 · 1 comment
Closed

Bad error message when passing transaction as ABI method argument #781

acfunk opened this issue May 11, 2023 · 1 comment

Comments

@acfunk
Copy link
Contributor

acfunk commented May 11, 2023

if (abiTypeIsTransaction(argType)) {
if (
!isTransactionWithSigner(argValue) ||
!abiCheckTransactionType(argType, argValue.txn)
) {
throw new Error(
`Expected ${argType} transaction for argument at index ${i}`
);
}

The error message should indicate TransactionWithSigner of the correct type is expected, not just Transaction of the correct type.

@Eric-Warehime
Copy link
Contributor

Merged in #780 Will be released in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants