Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyregTxn should not be instantiable. #219

Open
jkschin opened this issue Jul 31, 2021 · 1 comment
Open

KeyregTxn should not be instantiable. #219

jkschin opened this issue Jul 31, 2021 · 1 comment

Comments

@jkschin
Copy link
Contributor

jkschin commented Jul 31, 2021

Problem

In #209, we created the classes KeyregOnlineTxn, KeyregOfflineTxn and KeyregNonparticipatingTxn. They are all subclassed from KeyregTxn. Prior to #209, KeyregTxn can directly be instantiated and the differentiation is through what attributes are in that object.

Solution

I propose that we deprecate KeyregTxn since I don't think there's a use case for calling it directly.

Dependencies

Nil.

Urgency

This isn't urgent but it keeps the code base clean. If we definitely don't want KeyregTxn to be used in future, then it should be deprecated.

@jkschin jkschin added the new-feature-request Feature request that needs triage label Jul 31, 2021
@jkschin
Copy link
Contributor Author

jkschin commented Jul 31, 2021

@jasonpaulos I created this as a follow up to what we discussed in #209, I won't be working on it now and it's for posterity. Would love to hear your thoughts on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants