Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABI: Add Router routing graviton tests #394

Closed
michaeldiamant opened this issue Jun 14, 2022 · 2 comments
Closed

ABI: Add Router routing graviton tests #394

michaeldiamant opened this issue Jun 14, 2022 · 2 comments

Comments

@michaeldiamant
Copy link
Contributor

Problem

As of writing, pyteal does not implement graviton tests confirming ABI Router behavior. The story requests closing the gap by:

  • Adding facilities in graviton + pyteal to support automated testing.
  • Implementing at least 1 test that improves our correctness confidence.

Related: algorand/graviton#21 adds ABI routing tests to graviton. It's possible to imagine extending these facilities in pyteal.

Solution

Dependencies

Urgency

compiler_test.py offers baseline confidence because generated TEAL will change if a regression is introduced. So, the issue seems less dire than it may initially appear.

@tzaffi
Copy link
Contributor

tzaffi commented Jun 14, 2022

A couple of tasks that were mentioned in the graviton PR and are relevant to this issue:

  • Add graviton ABI Routing functionality in PyTEAL via ABIContractExecutor and use it to test more realistic programs such as.

@ahangsu ahangsu mentioned this issue Jan 19, 2023
6 tasks
@tzaffi
Copy link
Contributor

tzaffi commented Feb 9, 2023

#634 which is a child pr of #600 introduces the RouterSimulation class and tests/integration/abi_router_test.py for testing the router.

I'm closing the issue now as #600 is expected to merged in to master in the next couple of days.

@tzaffi tzaffi closed this as completed Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants