-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: improved error handling, snapshot tests for dispenser command #311
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aorumbayev It appears that we only have approval tests checking token refresh when invoking login
. Should we be checking token refresh via fund
, refund
and limit
?
tests/dispenser/TestLoginCommand.test_login_command_expired_token_refresh.False.approved.txt
Show resolved
Hide resolved
5ebdfd0
to
59dc99f
Compare
@neilcampbell added explicit batch of unit tests to test the behavior of refreshing the token instead of duplicating it in other methods, plus some minor refinements in the fixtures |
tests/dispenser/TestFundCommand.test_fund_command_http_error.approved.txt
Outdated
Show resolved
Hide resolved
tests/dispenser/TestFundCommand.test_fund_command_invalid_args.approved.txt
Show resolved
Hide resolved
tests/dispenser/TestFundCommand.test_fund_command_not_authenticated.approved.txt
Outdated
Show resolved
Hide resolved
tests/dispenser/TestFundCommand.test_fund_command_success.False.False.approved.txt
Outdated
Show resolved
Hide resolved
tests/dispenser/TestLoginCommand.test_login_command_already_logged_in.approved.txt
Outdated
Show resolved
Hide resolved
@neilcampbell @robdmoore ready for re-review. Latest tests rely on latest custom error responses from dispenser api |
tests/dispenser/TestLimitCommand.test_limit_command_success.False.False.approved.txt
Outdated
Show resolved
Hide resolved
tests/dispenser/TestLimitCommand.test_limit_command_success.False.True.approved.txt
Outdated
Show resolved
Hide resolved
* feat: wip poc for testnet dispenser interface * refactor: second revision for auth * chore: refining account codebase * chore: rev 5 wip changes * chore: tweaking accounts and scopes to account auth0 limitations per api * refactor: minor refinements for draft * chore: minor tweaks * chore: tweaking tests * chore: minor tweaks * chore: ignore gitpython pip-audit warnings; no fixes available yet * refactor: improving codebase and structure of dispense command * refactor: refining keyring to fit max limit for windows cred manager * docs: updating docs * refactor: improving network handling with custom group class * docs: adding initial docs on algokit dispense command (#310) * docs: adding initial docs on algokit dispense command * chore: addressing pr comments * refactor: addressing PR comments * docs: updating docs * refactor: addressing pr comments * Update src/algokit/cli/dispenser.py Co-authored-by: Neil Campbell <neil@codecise.com> * chore: apply suggestions from code review Co-authored-by: Neil Campbell <neil@codecise.com> * refactor: minor enhancements * chore: minor tweak in warning * docs: pushing docs * chore: updating login info statement * docs: fixing sphinx smart quotes * chore: addressing pr comments * docs: refining terminology in docs * refactor: improved error handling, snapshot tests for dispenser command (#311) * test: initial snapshot tests * test: adding snapshot tests * refactor: adding explicit tests for refreshing of the token * chore: recreating approved tests part 1 * chore: recreating approved tests part 2 * chore: partially addressing pr comments * chore: addressing remaining pr comments * chore: updating audience * chore: addressing pr comments * chore: replacing staging with prod * chore: pip audit * chore: updating docs with API docs --------- Co-authored-by: Neil Campbell <neil@codecise.com>
Proposed Changes