-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: algokit task - wallet aliasing #313
Conversation
@neilcampbell @robdmoore @Loedn Open questions
|
Coverage Report
|
@neilcampbell @robdmoore @Loedn, update so apparently max password len on windows is 1280 chars which is roughly ~60 aliases assuming worst case when max alias len used is 20 chars. I think 60 aliases is pretty reasonable amount - are we ok with throwing a warning that max number of aliases to persist is exhausted or we want unlimited storage for aliases? Storing it in keyring might get a bit tricky in case we want to remove limits --- Reply from @Loedn -> we will cap it at 50 aliases per user |
* feat: algokit task - wallet aliasing (#313) * feat: task wallet aliasing (add, get, remove, reset, list) * docs: regen docs * chore: minor tweaks * chore: pip-audit * chore: pip audit * chore: refining aliasing, initial tests * tests: extra snapshot tests * docs: adding docs and force flags * chore: typo fixes * chore: addressing pr comments * chore: tweaking docs * chore: updating docs * chore: adding extra docs * chore: fixing artifacts * feat: algokit task - vanity address (#314) * feat: implement task vanity_address * feat: adding logs in the process * refactor: minor changes on showing result * chore: fixing mypy * fix: using mnemonic instead of private key * test: adding some tests * chore: updating poetry lock file * docs: updating generated docs * test: updating generated tests * test: updating generated tests * docs: updating docs * test: add a test and updating other tests * chore: fixing tests * chore: extra tweaks in tests * test: some minor changes * chore: minor black formatting * test: fix the test for windows * chore: refining codebase; fixing multithreading * docs: initial docs; to be refined post aliasing pr merge * chore: fixing windows test * chore: addressing pr comments --------- Co-authored-by: Altynbek Orumbayev <altynbek.orumbayev@makerx.com.au> * refactor: adding support for storing vanity to aliases * docs: refreshing autogenerated docs * refactor: performance improvements for vanity; swifter termination handling (#319) * refactor: performance improvements for vanity; swifter termination handling * chore: graceful termination handling * chore: fixing test * feat: algokit task - transfer algo|asa (#315) * feat: implement task transfer * chore: fixing typo * feat: transfer command * chore: wip refactoring * feat: unit tests & docs * chore: poetry tweaks * chore: updating docs * chore: minor tweaks * chore: improving tests; smoke testing * docs: regen docs * chore: minor improvements * build: lock file maintenance * chore: minor improvements --------- Co-authored-by: inaie ignacio <inaie.ignacio@makerx.com.au> * feat: transaction signing task; polishing tasks (#324) * feat: transaction signing task; polishing tasks * docs: adding docstrings; refining task utils * test: adding snapshot tests * chore: regen docs * docs: adding docs * feat: deploy aliasing support (#323) * feat: adding aliasing support for deploy command * docs: updating docs * docs: regen docs * chore: minor polishing of click types on tasks * feat: dispenser fund command aliasing support (#325) * feat: task send transaction(s) (#326) * feat: send transaction task * test: snapshot tests * docs: regen docs * docs: adding command docs * fix: fixing decoding of dictified txns in sign method to support AppCall txns * chore: addressing pr comments * feat: ipfs upload (#327) * feat: ipfs upload * docs: adding snapshot tests and docs * docs: regen docs * chore: mypy tweaks * chore: pr comment * feat: nfd domains lookups (#328) * feat: nfd domains lookups * chore: pr comments * docs: regen docs * chore: mypy tweaks * feat: task `mint` (arc3 or arc19 compliant) (#329) * chore: wip arc19 minting * feat: draft implementation of minting using either arc3 or arc19 * chore: replacing py-multiformats-cid with multiformats * refactor: addressing pr comments * test: adding snapshot tests * docs: adding user facing docs * feat: task opt in and opt out (#331) * feat: adding initial optin command * fix: add network option * fix: adding help to the opt-in command * fix: adding network as an argument. * feat: adding opt in and opt out commands * chore: update urllib3 for pip audit * fix: fixing error handling, command order, tests * docs: updating documents * test: fixing tests * refactor: improving tests, adding docs and etc --------- Co-authored-by: Altynbek Orumbayev <altynbek.orumbayev@makerx.com.au> * chore: minor tweaks in vanity address performance (#333) * refactor: vanity generation * chore: wip * refactor: vanity generation * chore: refactor vanity generation * refactor: minor improvements in shared enums; docs * chore: bumping algokit-utils * docs: minor adjustments in transfer argument help str * chore: adjusting docs * chore: updating lockfile * chore: apply suggestions from code review Co-authored-by: Neil Campbell <neil@codecise.com> --------- Co-authored-by: Negar <negar.abbasi@makerx.com.au> Co-authored-by: inaie ignacio <inaie.ignacio@makerx.com.au> Co-authored-by: Neil Campbell <neil@codecise.com>
Proposed Changes
TODO
Further notes
Refactoring deploy command to support aliases are to be addressed in a separate PR