fix: increase discoverability of algokit resolve by id and name methods #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robdmoore
reviewed
Aug 21, 2023
aorumbayev
requested changes
Aug 21, 2023
| * @param deployTimeParams Optionally provide any deploy-time parameters to replace in the TEAL code; if specified here will get used in calls to `deploy`, `create` and `update` unless overridden in those calls | ||
| * @param name The optional name to use to mark the app when deploying `ApplicationClient.deploy` (default: uses the name in the ABI contract) | ||
| * | ||
| * @returns The application client |
There was a problem hiding this comment.
Can we also add a set of example docstrings for valid simple and copy-pasteable example invocation for getAppClientById, getAppClientByCreatorAndName and for getAppClient as well?
robdmoore
approved these changes
Aug 23, 2023
|
@inaie-makerx as discussed, a few more tweaks needed:
|
|
Good catch on |
aorumbayev
approved these changes
Aug 25, 2023
aorumbayev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://dev.azure.com/makerxstudio/AlgoKit%20(Algorand%20Foundation)/_backlogs/backlog/AlgoKit%20(Algorand%20Foundation)%20Team/Features/?showParents=true&workitem=714