Various bits of feedback about v7 #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: AlgoKitComposer.simulate() now has a `skipSignatures` option to opt-out of signing for the simulate call feat: Added a `defaultSigner` to `AppClient` and `AppFactory` feat: `AppClient` now has an `algorand` property so you don't need to pass `AlgorandClient` around everywhere if you have a client feat: `AppFactory` now has an `algorand` property so you don't need to pass `AlgorandClient` around everywhere if you have a factory feat: `AppFactory` now has `appName` and `appSpec` properties so if you want this information it's exposed rather than private feat: `appFactory.deploy` now allows you to override `appName` so if you want to create multiple contracts from a factory with different names you can BREAKING CHANGE: AppClient.compile (and appClient.compile, and appFactory.compile) return `compiledApproval` and `compiledClear` again This reverted the last commit after a reflection that the more explicit naming was actually confusing since it meant the return of this method different from the return from create/update calls and consistency was better. The fact there is now jsdoc comments means that the property names from the compile method are able to be quickly understood.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skipSignaturesoption to opt-out of signing for the simulate calldefaultSignertoAppClientandAppFactoryAppClientnow has analgorandproperty so you don't need to passAlgorandClientaround everywhere if you have a clientAppFactorynow has analgorandproperty so you don't need to passAlgorandClientaround everywhere if you have a factoryAppFactorynow hasappNameandappSpecproperties so if you want this information it's exposed rather than privateappFactory.deploynow allows you to overrideappNameso if you want to create multiple contracts from a factory with different names you cancompiledApprovalandcompiledClearagain This reverted the last commit after a reflection that the more explicit naming was actually confusing since it meant the return of this method different from the return from create/update calls and consistency was better. The fact there is now jsdoc comments means that the property names from the compile method are able to be quickly understood.