Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define code style for spark and java and add code format check to CI #232

Merged
merged 8 commits into from
Sep 6, 2023

Conversation

acezen
Copy link
Contributor

@acezen acezen commented Sep 6, 2023

Proposed changes

  • Defind code format style for scala and java
  • Add code format check to CI
  • Add dev container configuration

Types of changes

What types of changes does your code introduce to GraphAr?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Fixed #224

@acezen acezen changed the title Add code check for spark and java Define code format for spark and java and add code format check to CI Sep 6, 2023
@acezen acezen changed the title Define code format for spark and java and add code format check to CI Define code style for spark and java and add code format check to CI Sep 6, 2023
@acezen acezen marked this pull request as ready for review September 6, 2023 06:51
@acezen acezen requested a review from lixueclaire September 6, 2023 06:51
@acezen acezen merged commit d095ee6 into apache:main Sep 6, 2023
@acezen acezen deleted the 224-code-format-java-scala branch September 6, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] Code format for Java and Spark
1 participant