Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The GraphBuilder test cases can be categorized into two test groups of Algebra and Expression #3599

Open
longbinlai opened this issue Mar 4, 2024 · 1 comment

Comments

@longbinlai
Copy link
Collaborator

Now in interactive_engine/compiler/src/test/java/com/alibaba/graphscope/gremlin/antlr4x/GraphBuilderTest.java, there are two kinds of test cases.

The Algebra case: For example,
RelNode node = eval("g.V().has('name', containing('mar'))"), as introduced by the eval() function.

The Expression case: For example,
RexNode expr = rexBuilder.makeIn( builder.source(new SourceConfig(GraphOpt.Source.VERTEX)) .variable(null, GraphProperty.ID_KEY), ImmutableList.of(builder.literal(0), builder.literal(72057594037927937L))); ,
as introduced by RexBuilder directly.

We can separate these two kinds of test cases into two individual tests.

Copy link
Contributor

/cc @shirly121, this issus/pr has had no activity for for a long time, could you folks help to review the status ?
To suppress further notifications,

  • for issues,
    • if it is waiting for further response from the reporter/author, please help to add the label requires-further-info,
    • if you have already started working on it, please add the label work-in-progress to the issue,
    • if this issue requires further designing discussion and not in current plan, or won't be fixed, please add the label requires-further-discussion or wontfix to the issue,
  • for pull requests,
    • if you are still working on it and it is not ready for reviewing, please convert this pull request as draft PR,
    • if you have decided to hold this development on, please add the requires-further-discussion label to the pull request.
      Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants