Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

关于项目内 boolean类型的判断 #1650

Closed
smipo opened this issue Aug 10, 2020 · 2 comments · Fixed by #1664
Closed

关于项目内 boolean类型的判断 #1650

smipo opened this issue Aug 10, 2020 · 2 comments · Fixed by #1664
Assignees
@PeineLiang
Labels
good first issue Good for newcomers

Comments

@smipo
Copy link

smipo commented Aug 10, 2020

关于xx == true 这个判断在项目存在两处 是否需要改掉

image
@sczyh30 sczyh30 added the good first issue Good for newcomers label Aug 11, 2020
@sczyh30
Copy link
Member

sczyh30 commented Aug 11, 2020

You may submit a PR to improve it :)

@PeineLiang PeineLiang mentioned this issue Aug 12, 2020
Closed
@PeineLiang
Copy link
Contributor

Please assign to me

@PeineLiang PeineLiang mentioned this issue Aug 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PeineLiang PeineLiang

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bugfix: fix xx == true PeineLiang/Sentinel
bugfix: fix xx == true PeineLiang/Sentinel
3 participants
@sczyh30 @PeineLiang @smipo