Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Threshold of rate limiting mode does not support 1000 #259

Closed
Black-Mamba24 opened this issue Nov 22, 2018 · 1 comment · Fixed by #2951
Closed

[Bug] Threshold of rate limiting mode does not support 1000 #259

Black-Mamba24 opened this issue Nov 22, 2018 · 1 comment · Fixed by #2951
Assignees
Labels
area/flow-control Issues or PRs related to flow control kind/bug Category issues or prs related to bug.
Milestone

Comments

@Black-Mamba24
Copy link

Black-Mamba24 commented Nov 22, 2018

Issue Description

Type: bug report or feature request

Describe what happened (or what feature you want)

When config 1000, It works normally, config 2000 also limit at 1000tps, when I try 5000, sentinel breakdown

Describe what you expected to happen

I think limiter should support higher count, more than 1000.

How to reproduce it (as minimally and precisely as possible)

  1. rule1.setControlBehavior(RuleConstant.CONTROL_BEHAVIOR_RATE_LIMITER);rule1.setCount(2000);

Tell us your environment

linux and win

Anything else we need to know?

@Black-Mamba24 Black-Mamba24 changed the title Limiter TPS Limiter Count Not Support More Than 1000 Nov 22, 2018
@sczyh30 sczyh30 added the kind/enhancement Category issues or prs related to enhancement. label Nov 22, 2018
@sczyh30
Copy link
Member

sczyh30 commented Nov 26, 2018

Hi, currently the rate limiter does not support threshold above 1000 (which means interval < 1ms). We'll address the issue and support microsecond-level interval. Thanks for reporting!

@sczyh30 sczyh30 changed the title Limiter Count Not Support More Than 1000 [Bug] Threshold of rate limiting mode does not support 1000 Nov 30, 2018
@sczyh30 sczyh30 added kind/bug Category issues or prs related to bug. and removed kind/enhancement Category issues or prs related to enhancement. labels Nov 30, 2018
@sczyh30 sczyh30 added this to the 1.4.0 milestone Nov 30, 2018
@sczyh30 sczyh30 self-assigned this Nov 30, 2018
@sczyh30 sczyh30 removed this from the 1.4.0 milestone Dec 14, 2018
@sczyh30 sczyh30 added the area/flow-control Issues or PRs related to flow control label Jul 16, 2019
@sczyh30 sczyh30 added this to the 1.8.1 milestone Jul 19, 2020
@sczyh30 sczyh30 modified the milestones: 1.8.1, 1.8.2 Jan 18, 2021
@sczyh30 sczyh30 removed this from the 1.8.2 milestone Jan 29, 2021
@sczyh30 sczyh30 added this to the v2.0.0 milestone Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/flow-control Issues or PRs related to flow control kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants