Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: record rule ID in Sentinel | 希望能够在客户端保存规则的Id #2851

Closed
brucelwl opened this issue Aug 29, 2022 · 2 comments · Fixed by #2853
Closed

feature: record rule ID in Sentinel | 希望能够在客户端保存规则的Id #2851

brucelwl opened this issue Aug 29, 2022 · 2 comments · Fixed by #2853
Labels
good first issue Good for newcomers kind/feature Category issues or prs related to feature request.

Comments

@brucelwl
Copy link

brucelwl commented Aug 29, 2022 •
edited
Loading

服务端存储了rule的Id, 但是客户端并没有保存., 希望客户端也能够保存一下, 并且在sentinel-block.log中能够打印ruleId, 这样可以在规则比较多时候知道具体是触发的哪个规则的阈值
@sczyh30 sczyh30 added good first issue Good for newcomers kind/feature Category issues or prs related to feature request. labels Aug 29, 2022
@sczyh30 sczyh30 changed the title feature: 希望能够在客户端保存规则的Id feature: record rule ID in Sentinel | 希望能够在客户端保存规则的Id Aug 29, 2022
@icodening icodening mentioned this issue Aug 29, 2022
Merged
@icodening
Copy link
Contributor

这个需求看起来也比较合理实现也简单，我这边提了个PR

@brucelwl
Copy link
Author

这个需求看起来也比较合理实现也简单，我这边提了个PR
@icodening 优秀

@brucelwl brucelwl mentioned this issue Apr 11, 2023
Merged
This was referenced Jun 3, 2023
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers kind/feature Category issues or prs related to feature request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

optimize BlockException log icodening/Sentinel
3 participants
@sczyh30 @brucelwl @icodening