fix(core): fix array child reactions invalid with remove (#3063)

alibaba · Apr 21, 2022 · 34e9420 · 34e9420
1 parent 82cd80a
commit 34e9420
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 6 deletions.
diff --git a/packages/core/src/__tests__/array.spec.ts b/packages/core/src/__tests__/array.spec.ts
@@ -698,9 +698,20 @@ test('array field remove can not memory leak', async () => {
       basePath: 'array.1',
     })
   )
+  const bb = attach(
+    form.createField({
+      name: 'bb',
+      basePath: 'array.1',
+      reactions: (field) => {
+        field.visible = field.query('.aa').value() === '123'
+      },
+    })
+  )
+  expect(bb.visible).toBeFalsy()
   await array.remove(0)
   form.query('array.0.aa').take((field) => {
     ;(field as DataField).value = '123'
   })
-  expect(handler).toBeCalledTimes(2)
+  expect(bb.visible).toBeTruthy()
+  expect(handler).toBeCalledTimes(1)
 })
diff --git a/packages/core/src/shared/internals.ts b/packages/core/src/shared/internals.ts
@@ -163,7 +163,6 @@ export const patchFieldStates = (
       if (payload) {
         target[address] = payload
         if (target[oldAddress] === payload) {
-          target[oldAddress]?.dispose()
           delete target[oldAddress]
         }
       }
@@ -387,10 +386,11 @@ export const spliceArrayState = (
     if (number === undefined) return false
     const index = Number(number)
     return (
-      index >= startIndex &&
-      !fields[
-        `${preStr}${afterStr.replace(/^\.\d+/, `.${index + deleteCount}`)}`
-      ]
+      (index > startIndex &&
+        !fields[
+          `${preStr}${afterStr.replace(/^\.\d+/, `.${index + deleteCount}`)}`
+        ]) ||
+      index === startIndex
     )
   }
   const moveIndex = (identifier: string) => {