fix(core): fix field destructor name will cause stack overflow (#3524)

alibaba · Nov 7, 2022 · 7306677 · 7306677
1 parent f35e5df
commit 7306677
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 3 deletions.
diff --git a/packages/core/src/__tests__/field.spec.ts b/packages/core/src/__tests__/field.spec.ts
@@ -2334,3 +2334,15 @@ test('field hidden value', () => {
   expect(objectField.value).toEqual({})
   expect(arrayField.value).toEqual([])
 })
+
+test('field destructor path with display none', () => {
+  const form = attach(createForm())
+  const aa = attach(
+    form.createArrayField({
+      name: '[aa,bb]',
+    })
+  )
+  aa.setDisplay('none')
+  expect(form.values).toEqual({})
+  expect(aa.value).toEqual([])
+})
diff --git a/packages/core/src/models/Field.ts b/packages/core/src/models/Field.ts
@@ -1,4 +1,10 @@
-import { isValid, toArr, FormPathPattern, isArr } from '@formily/shared'
+import {
+  isValid,
+  isEmpty,
+  toArr,
+  FormPathPattern,
+  isArr,
+} from '@formily/shared'
 import {
   ValidatorTriggerType,
   parseValidatorDescriptions,
@@ -47,7 +53,7 @@ import {
 } from '../shared/internals'
 import { Form } from './Form'
 import { BaseField } from './BaseField'
-import { IFormFeedback } from '..'
+import { IFormFeedback } from '../types'
 export class Field<
   Decorator extends JSXComponent = any,
   Component extends JSXComponent = any,
@@ -222,7 +228,7 @@ export class Field<
             if (this.selfModified && !this.caches.inputting) {
               validateSelf(this)
             }
-            if (this.display === 'none') {
+            if (!isEmpty(value) && this.display === 'none') {
               this.caches.value = toJS(value)
               this.form.deleteValuesIn(this.path)
             }