fix(reactive): fix unexpect effect in reactions (#2563)

alibaba · Dec 3, 2021 · 8f8db67 · 8f8db67
1 parent 35a18c4
commit 8f8db67
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 0 deletions.
diff --git a/packages/core/src/__tests__/field.spec.ts b/packages/core/src/__tests__/field.spec.ts
@@ -1,4 +1,5 @@
 import { createForm } from '../'
+import { DataField } from '../types'
 import { attach, sleep } from './shared'
 
 test('create field', () => {
@@ -1810,3 +1811,26 @@ test('custom validator to get ctx.field', async () => {
   expect(!!ctxField).toBeTruthy()
   expect(!!ctxForm).toBeTruthy()
 })
+
+test('single direction linkage effect', async () => {
+  const form = attach(createForm())
+
+  const input1 = form.createField({
+    name: 'input1',
+    reactions: (field: DataField) => {
+      if (!field.selfModified) {
+        return
+      }
+      input2.value = field.value
+    },
+  })
+
+  const input2 = form.createField({
+    name: 'input2',
+  })
+
+  await input1.onInput('123')
+  expect(input2.value).toBe('123')
+  await input2.onInput('321')
+  expect(input2.value).toBe('321')
+})
diff --git a/packages/reactive/src/autorun.ts b/packages/reactive/src/autorun.ts
@@ -5,6 +5,8 @@ import {
   releaseBindingReactions,
   disposeEffects,
   hasDepsChange,
+  untrackStart,
+  untrackEnd,
 } from './reaction'
 import { isFn } from './checkers'
 import { ReactionStack } from './environment'
@@ -117,10 +119,12 @@ export const reaction = <T>(
 
   const fireAction = () => {
     try {
+      untrackStart()
       batchStart()
       if (isFn(subscriber)) subscriber(value.currentValue, value.oldValue)
     } finally {
       batchEnd()
+      untrackEnd()
     }
   }