Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Windows Support for iLogtail #327

Closed
yyuuttaaoo opened this issue Aug 19, 2022 · 6 comments · Fixed by #745
Closed

[FEATURE]: Windows Support for iLogtail #327

yyuuttaaoo opened this issue Aug 19, 2022 · 6 comments · Fixed by #745
Labels
community Hope the community contributes feature request New feature request
Milestone

Comments

@yyuuttaaoo
Copy link
Collaborator

Concisely describe the proposed feature
Compile and run ilogtail on Windows.

Describe the solution you'd like (if any)

@yyuuttaaoo yyuuttaaoo added the feature request New feature request label Aug 19, 2022
@yyuuttaaoo
Copy link
Collaborator Author

Resources:

  • Dependencies
    https://ilogtail-community-edition.oss-cn-shanghai.aliyuncs.com/prebuilt-dependencies/ilogtail-deps.windows-386.zip

  • An initial version of the build script
    build.bat.txt

  • Known problems to fix

    diff --git a/core/common/util.cpp b/core/common/util.cpp
    index 0843f1b..4c3144f 100644
    --- a/core/common/util.cpp
    +++ b/core/common/util.cpp
    @@ -25,7 +25,6 @@
     #include <execinfo.h>
     #elif defined(_MSC_VER)
     #include <Rpc.h>
    -#include "WinUuid.h"
     #endif
     #include "logger/Logger.h"
     #include "StringTools.h"
    diff --git a/core/observer/network/NetworkConfig.h b/core/observer/network/NetworkConfig.h
    index 3ebd798..2b91f14 100644
    --- a/core/observer/network/NetworkConfig.h
    +++ b/core/observer/network/NetworkConfig.h
    @@ -16,6 +16,8 @@
    
     #pragma once
    
    +#include <numeric>
    +
     #include "common/Flags.h"
     #include "config/Config.h"
     #include "interface/type.h"
    diff --git a/core/plugin/LogtailPlugin.h b/core/plugin/LogtailPlugin.h
    index d427a87..b70ced6 100644
    --- a/core/plugin/LogtailPlugin.h
    +++ b/core/plugin/LogtailPlugin.h
    @@ -17,6 +17,7 @@
     #pragma once
     #include <cstdint>
     #include <cstdlib>
    +#include <numeric>
     #include <ostream>
     #include <json/json.h>
     #include "config/Config.h"
    

@yyuuttaaoo yyuuttaaoo added this to the v1.1.2 milestone Aug 19, 2022
@messixukejia messixukejia added the community Hope the community contributes label Aug 25, 2022
@yyuuttaaoo
Copy link
Collaborator Author

An updated build.bat and compile guide. There should be enough to complete "Fix windows compilation problems" task and a potential solution for Windows build.
Windows编译.pdf
build.bat.txt

@yyuuttaaoo yyuuttaaoo modified the milestones: v1.1.2, v1.3.0 Sep 23, 2022
@liuhaoyang
Copy link
Collaborator

Is there any progress on windows support ?

@messixukejia
Copy link
Collaborator

Is there any progress on windows support ?

The necessary steps have been provided as above. Interested developers in the community are welcome to claim them and complete the remaining tasks according to the above ideas.

@yyuuttaaoo
Copy link
Collaborator Author

code patch was committed in #556

@yyuuttaaoo
Copy link
Collaborator Author

If you want to use ilogtail as a service, you may wrap it by winsw

@yyuuttaaoo yyuuttaaoo modified the milestones: v1.4, v1.5 Mar 21, 2023
@yyuuttaaoo yyuuttaaoo linked a pull request Mar 27, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Hope the community contributes feature request New feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants