Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug of ConnectionControlManager: During initialization, when no connection limit rules are found, it should use RuleParser to create a blank rule, rather than directly creating a ConnectionControlRule. #12397

Closed
Sunrisea opened this issue Jul 22, 2024 · 0 comments · Fixed by #12399
Labels
kind/bug Category issues or prs related to bug. plugin

Comments

@Sunrisea
Copy link
Contributor

Describe the bug
The ConnectionControlManager class has a bug: During initialization, when no connection limit rules are found, it should use RuleParser to create a blank rule, rather than directly creating a ConnectionControlRule.
ConnectionControlManager类存在bug:初始化时,当查询不到链接限制规则时,应该使用RuleParser来新建空白规则,而不是直接创建ConnectionControlRule,这会对扩展性造成损伤

Expected behavior
Use RuleParser to create a blank rule

Actually behavior
directly creating a ConnectionControlRule

How to Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See errors

Desktop (please complete the following information):

  • OS: [e.g. Centos]
  • Version [e.g. nacos-server 1.3.1, nacos-client 1.3.1]
  • Module [e.g. naming/config]
  • SDK [e.g. original, spring-cloud-alibaba-nacos, dubbo]

Additional context
Add any other context about the problem here.

@KomachiSion KomachiSion added kind/bug Category issues or prs related to bug. plugin labels Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Category issues or prs related to bug. plugin
Projects
None yet
2 participants