Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] 建议不允许创建id为public的namespace,会和保留默认的namespace造成严重混淆 #9773

Open
wilsonwu opened this issue Dec 30, 2022 · 5 comments
Labels
kind/enhancement Category issues or prs related to enhancement.

Comments

@wilsonwu
Copy link
Contributor

Describe the bug
用户创建id为public的namespace会造成服务接入时的问题混淆,由于默认情况namespace id为空或为public都可以接入保留namespace。

Expected behavior
主要是增强产品体验和容错

Actually behavior
造成用户混淆

@xzxiaoshan
Copy link
Contributor

建议调整 create 接口并提交PR给作者

@KomachiSion
Copy link
Collaborator

refer to #3525

@KomachiSion KomachiSion added the kind/enhancement Category issues or prs related to enhancement. label Jan 3, 2023
@wilsonwu
Copy link
Contributor Author

wilsonwu commented Jan 5, 2023

建议调整 create 接口并提交PR给作者

#9803 please help to review.

@xzxiaoshan
Copy link
Contributor

#9846 中做了讨论,即使用户创建了public命名空间,也是无法正常使用的。目前nacos将public和"" 都视为默认命名空间。

但是能创建ID为public的命名空间,也是理应避免的。

@wilsonwu
Copy link
Contributor Author

#9846 中做了讨论,即使用户创建了public命名空间,也是无法正常使用的。目前nacos将public和"" 都视为默认命名空间。

但是能创建ID为public的命名空间,也是理应避免的。

在我测试过程中发现,服务注册(没有测试配置中心)的场景如果创建public为id的namespace,注册功能是没有异常的,只是会混淆,可以考虑禁止public为id的namespace创建,#9803 这个PR可以考虑合并。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants