Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daemon should handle npm packages from different sources #579

Closed
rickycao-qy opened this issue Sep 9, 2020 · 1 comment
Closed

Daemon should handle npm packages from different sources #579

rickycao-qy opened this issue Sep 9, 2020 · 1 comment
Assignees
Labels

Comments

@rickycao-qy
Copy link
Collaborator

rickycao-qy commented Sep 9, 2020

We are supporting four different sources of npm packages now: npm registry / git address / url download / local upload.

The problem is that we mix up these different sources and cannot distinguish between them after installed. Pipcook now will only record the package name. So if you want to fetch information about this package, you will by default fetch it from npm registry and it probably does not exist in npm at all.

We need to change the way that when the source is git/url/upload, we save the package, fetch the package info, compare md5 with former packages and install them accordingly. Meanwhile, we need to record the original source.

image

@FeelyChau
Copy link
Collaborator

Daemon has been removed in v2, this issue should be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants