test: add mock test for network operations on client side #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1020 +/- ##
==========================================
+ Coverage 14.21% 14.58% +0.36%
==========================================
Files 127 130 +3
Lines 8474 8481 +7
==========================================
+ Hits 1205 1237 +32
+ Misses 7169 7144 -25
Partials 100 100
Continue to review full report at Codecov.
|
allencloud
reviewed
Apr 2, 2018
client/network_create_test.go
Outdated
| return nil, err | ||
| } | ||
| return &http.Response{ | ||
| StatusCode: http.StatusOK, |
There was a problem hiding this comment.
I think this API should return 201 StatusCreated, if it works with no error.
allencloud
reviewed
Apr 2, 2018
| return nil, err | ||
| } | ||
|
|
||
| network := &types.NetworkListResp{} |
There was a problem hiding this comment.
I do not think the naming of network makes sense.
Maybe netListResp := &types.NetworkListResp{} is a little better.
allencloud
reviewed
Apr 2, 2018
client/network_remove_test.go
Outdated
| } | ||
|
|
||
| return &http.Response{ | ||
| StatusCode: http.StatusOK, |
There was a problem hiding this comment.
StatusNoContent, rather than StatusOK.
Signed-off-by: Zou Rui <21751189@zju.edu.cn>
ZouRui89
changed the title
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zou Rui 21751189@zju.edu.cn
Ⅰ. Describe what this PR did
add mock test for all the network operations on client side
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews