feature: add options when using volume list #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rudyfly code conflict, please rebase your code, thanks a lot. |
rudyfly
force-pushed
the
volume-list
branch
2 times, most recently
from
733691a
to
7d96f9b
Compare
allencloud
reviewed
Apr 2, 2018
volume/types/volume.go
Outdated
| @@ -191,6 +191,11 @@ func (v *Volume) Key() string { | |||
| return v.Name | |||
| } | |||
|
|
|||
| //CreateTime returns the volume's create time. | |||
| func (v *Volume) CreateTime() string { | |||
| return v.CreationTimestamp.Format("2006-1-2 15:04:05") | |||
There was a problem hiding this comment.
I found that in the definition we have:
// CreationTimestamp is a timestamp representing the server time when this object was
// created. It is not guaranteed to be set in happens-before order across separate operations.
// Clients may not set this value. It is represented in RFC3339 form and is in UTC.
CreationTimestamp *time.Time `json:"CreationTimestamp,omitempty"`
It seems to be a pointer, so I am wondering if we need to detect it is non-nil ?
Codecov Report
@@ Coverage Diff @@
## master #1028 +/- ##
=========================================
Coverage ? 15.15%
=========================================
Files ? 135
Lines ? 8499
Branches ? 0
=========================================
Hits ? 1288
Misses ? 7110
Partials ? 101
Continue to review full report at Codecov.
|
Add options when using volume list, add volume driver into default volume list information. Add list volumes function in volume core module. Signed-off-by: Rudy Zhang <rudyflyzhang@gmail.com>
allencloud
reviewed
Apr 2, 2018
|
|
||
| for _, v := range volumeList.Volumes { | ||
| display.AddRow([]string{v.Name}) | ||
| displayHead := []string{"DRIVER", "VOLUME NAME"} |
There was a problem hiding this comment.
Could you help to change VOLUME NAME into VOLUME_NAME to avoid others to think that NAME is another column? @rudyfly
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Add options when using volume list, add volume driver into default
volume list information. Add list volumes function in volume core module.
Ⅱ. Does this pull request fix one issue?
fixes #921
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
listing volume format is "DRIVER VOLUME NAME", you can add some options, such as size and mountpoint, list volume with options like this:
Ⅴ. Special notes for reviews
Signed-off-by: Rudy Zhang rudyflyzhang@gmail.com