bugfix: modify volume inspect docs #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZouRui89
reviewed
Apr 2, 2018
cli/volume.go
Outdated
| Use: "inspect [OPTIONS] NAME", | ||
| Short: "Inspect a pouch volume", | ||
| Use: "inspect [OPTIONS] Volume [Volume...]", | ||
| Short: "Inspect pouch one or more volumes", |
There was a problem hiding this comment.
I guess "Inspect one or more pouch volumes" is better.
There was a problem hiding this comment.
thanks a lot for your work, i think we should also fix network inspect command !
Codecov Report
@@ Coverage Diff @@
## master #1029 +/- ##
==========================================
+ Coverage 14.91% 15.17% +0.25%
==========================================
Files 133 135 +2
Lines 8483 8490 +7
==========================================
+ Hits 1265 1288 +23
+ Misses 7118 7101 -17
- Partials 100 101 +1
Continue to review full report at Codecov.
|
modify volume inspect docs, it supports to inspect multi-volumes. Signed-off-by: Rudy Zhang <rudyflyzhang@gmail.com>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
modify volume inspect docs, it supports to inspect multi-volumes,
and supports to inspect volume with format.
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
Signed-off-by: Rudy Zhang rudyflyzhang@gmail.com