Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: for privileged container, make some paths not be readonly #1055

Merged

Conversation

YaoZengzeng
Copy link
Contributor

Signed-off-by: YaoZengzeng yaozengzeng@zju.edu.cn

Ⅰ. Describe what this PR did

By default, some paths like /proc/sys is readonly.

However if it is the privileged container, these paths should not be only readable.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: YaoZengzeng <yaozengzeng@zju.edu.cn>
@pouchrobot pouchrobot added kind/bug This is bug report for project size/S labels Apr 4, 2018
@codecov-io
Copy link

Codecov Report

Merging #1055 into master will increase coverage by 0.09%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1055      +/-   ##
==========================================
+ Coverage   16.17%   16.26%   +0.09%     
==========================================
  Files         140      140              
  Lines        8557     8519      -38     
==========================================
+ Hits         1384     1386       +2     
+ Misses       7070     7030      -40     
  Partials      103      103
Impacted Files Coverage Δ
daemon/mgr/spec_volume.go 0% <0%> (ø) ⬆️
cli/cli.go 0% <0%> (ø) ⬆️
client/client.go 28.57% <0%> (+5.49%) ⬆️

@YaoZengzeng
Copy link
Contributor Author

@allencloud PTAL.

@allencloud
Copy link
Collaborator

LGTM

@allencloud allencloud merged commit c4ce04f into AliyunContainerService:master Apr 8, 2018
@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Apr 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants