test:add container remove and stop test #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1064 +/- ##
==========================================
- Coverage 16.47% 15.97% -0.51%
==========================================
Files 156 142 -14
Lines 8724 8509 -215
==========================================
- Hits 1437 1359 -78
+ Misses 7183 7047 -136
+ Partials 104 103 -1
|
ZouRui89
reviewed
Apr 7, 2018
client/container_remove_test.go
Outdated
| return nil, fmt.Errorf("force not set in URL properly. Expected 'true', got %s", force) | ||
| } | ||
| return &http.Response{ | ||
| StatusCode: http.StatusOK, |
There was a problem hiding this comment.
The status code here should be 'http.StatusNoContent'.
Signed-off-by: Dewey-Ding <deweyding@gmail.com>
|
LGTM @allencloud |
|
Thanks for your work @Dewey-Ding and your review @ZouRui89 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dewey-Ding deweyding@gmail.com
Ⅰ. Describe what this PR did
add container remove and stop test
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews