test: refine daemon framework #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: letty <letty.ll@alibaba-inc.com>
Letty5411
changed the title
Signed-off-by: letty <letty.ll@alibaba-inc.com>
Codecov Report
@@ Coverage Diff @@
## master #1078 +/- ##
==========================================
+ Coverage 16.52% 16.53% +0.01%
==========================================
Files 161 161
Lines 8884 8900 +16
==========================================
+ Hits 1468 1472 +4
- Misses 7313 7323 +10
- Partials 103 105 +2
|
|
Is this still in WIP? @Letty5411 |
Letty5411
changed the title
|
@allencloud It has been ready for reviewing. |
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: letty letty.ll@alibaba-inc.com
Ⅰ. Describe what this PR did
Refine the daemon test framework.
Add util functions in util_daemon.go, you could use it to start a new daemon and send request to this daemon.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews