-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: gocyclo issues in go report #1084
fix: gocyclo issues in go report #1084
Conversation
@zhuangqh Thanks for your contribution. 🍻 |
We found this is your first time to contribute to Pouch, @zhuangqh |
Codecov Report
@@ Coverage Diff @@
## master #1084 +/- ##
==========================================
- Coverage 16.2% 16.15% -0.06%
==========================================
Files 161 158 -3
Lines 8850 8842 -8
==========================================
- Hits 1434 1428 -6
+ Misses 7312 7310 -2
Partials 104 104
|
@@ -66,7 +66,7 @@ func canonicalAddr(url *url.URL) string { | |||
// change no_proxy to noProxy for avoid fail in go lint check | |||
var ( | |||
noProxyEnv = &envOnce{ | |||
names: []string{"NO_PROXY", "noProxy"}, | |||
names: []string{"NO_PROXY", "no_proxy"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you help to confirm this? Since I think it is introduced by your part. @Ace-Tang
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have communicated with @Ace-Tang offline. The change is totally reasonable.
LGTM |
1 similar comment
LGTM |
Thank @zhuangqh for your first contribution. |
Oh, I have forgotten to squash the four commits into a single one. My fault. |
Sorry my fault. I have read the contributing guide carefully. 😅 @allencloud |
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #964
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews