test: add tests for label and config file in daemon #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Letty5411
force-pushed
the
0410
branch
2 times, most recently
from
9a9a113 to
56e2f40
Compare
Letty5411
force-pushed
the
0410
branch
2 times, most recently
from
f3f2925 to
b853d2b
Compare
Letty5411
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1087 +/- ##
==========================================
+ Coverage 16.29% 16.47% +0.17%
==========================================
Files 161 161
Lines 8851 8870 +19
==========================================
+ Hits 1442 1461 +19
- Misses 7303 7306 +3
+ Partials 106 103 -3
|
HusterWan
reviewed
Apr 10, 2018
test/daemon/daemon.go
Outdated
| @@ -148,7 +152,17 @@ func (d *Config) StartDaemon() error { | |||
| if util.WaitTimeout(time.Duration(d.timeout)*time.Second, d.IsDaemonUp) == false { | |||
| if d.Debug == true { | |||
| d.DumpLog() | |||
|
|
|||
| fmt.Printf("\n") | |||
| fmt.Printf("Failed to launch pouchd:%v\n", d.Args) | |||
There was a problem hiding this comment.
maybe we could use fmt.Printf("\nFailed to launch pouchd:%v\n", d.Args)
test/z_cli_daemon_test.go
Outdated
| c.Assert(err, check.IsNil) | ||
|
|
||
| // verify listen to tcp works | ||
| command.PouchRun("--host", addr, "version").Assert(c, icmd.Success) | ||
|
|
||
| dcfg.KillDaemon() | ||
| defer dcfg.KillDaemon() |
test/z_cli_daemon_test.go
Outdated
| c.Assert(err, check.NotNil) | ||
| } | ||
|
|
||
| // TestDaemonConfigFileUnknownFlag tests start daemon with unknow flags in configure file. |
Letty5411
force-pushed
the
0410
branch
2 times, most recently
from
fa51637 to
a13d235
Compare
Signed-off-by: letty <letty.ll@alibaba-inc.com>
|
@HusterWan code is ready, PTAL. |
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: letty letty.ll@alibaba-inc.com
Ⅰ. Describe what this PR did
Add deamon tests for ：
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews