test:add container resize and restart test #1090
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1090 +/- ##
==========================================
- Coverage 16.47% 16.39% -0.09%
==========================================
Files 161 163 +2
Lines 8921 8813 -108
==========================================
- Hits 1470 1445 -25
+ Misses 7347 7264 -83
Partials 104 104
|
|
Could you help to review this? @ZouRui89 |
client/container_resize_test.go
Outdated
|
|
||
| httpClient := newMockClient(func(req *http.Request) (*http.Response, error) { | ||
| if !strings.HasPrefix(req.URL.Path, expectedURL) { | ||
| return nil, fmt.Errorf("Expected URL '%s', got '%s'", expectedURL, req.URL) |
There was a problem hiding this comment.
According to the code style rules of pouch, No matter log or error, first letter of the message must be lower-case
There was a problem hiding this comment.
I am following the example write by allencloud in issue #966 .Is there special?
There was a problem hiding this comment.
I am afraid that @zhuangqh has made a point and we should change all the case problem in mock test. And I have noticed that the same problem exists in other part of Pouch. WDYT? @allencloud
There was a problem hiding this comment.
@Dewey-Ding Could you fix the case problem? Thx a lot.
There was a problem hiding this comment.
maybe i can do it in this pr.
There was a problem hiding this comment.
Signed-off-by: Dewey-Ding <deweyding@gmail.com>
|
LGTM |
Signed-off-by: Dewey-Ding deweyding@gmail.com
Ⅰ. Describe what this PR did
add container resize and restart test
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews