test:add container create test #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1106 +/- ##
==========================================
+ Coverage 15.8% 16.75% +0.94%
==========================================
Files 163 165 +2
Lines 8793 8906 +113
==========================================
+ Hits 1390 1492 +102
- Misses 7300 7308 +8
- Partials 103 106 +3
|
ZouRui89
reviewed
Apr 12, 2018
| httpClient := newMockClient(func(req *http.Request) (*http.Response, error) { | ||
| if !strings.HasPrefix(req.URL.Path, expectedURL) { | ||
| return nil, fmt.Errorf("expected URL '%s', got '%s'", expectedURL, req.URL) | ||
| } |
There was a problem hiding this comment.
I think this test can be enhanced. Would you check the type of the request or the data type that the request method gets, which can improve the degree of accuracy greatly. Thx a lot!
client/container_create_test.go
Outdated
| } | ||
| if container.ID != "container_id" { | ||
| t.Fatalf("expected `container_id`, got %s", container.ID) | ||
| } |
There was a problem hiding this comment.
You can assert the value of both id and name here, instead of just that of id.
|
You can refer to similar mock test, such as 'network create' and 'volume create'. |
Signed-off-by: Dewey-Ding <deweyding@gmail.com>
|
@ZouRui89 PTAL |
|
Well done! LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dewey-Ding deweyding@gmail.com
Ⅰ. Describe what this PR did
add container create test
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews