-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: make inspect output an array #1119
Merged
allencloud
merged 1 commit into
AliyunContainerService:master
from
faycheng:fix-multi-inspect
Apr 12, 2018
Merged
bugfix: make inspect output an array #1119
allencloud
merged 1 commit into
AliyunContainerService:master
from
faycheng:fix-multi-inspect
Apr 12, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 程飞 <fay.cheng.cn@gmail.com>
faycheng
force-pushed
the
fix-multi-inspect
branch
from
April 12, 2018 07:36
9b7b41f
to
12ebcac
Compare
Codecov Report
@@ Coverage Diff @@
## master #1119 +/- ##
==========================================
- Coverage 16.66% 16.59% -0.07%
==========================================
Files 165 165
Lines 8911 8894 -17
==========================================
- Hits 1485 1476 -9
+ Misses 7321 7313 -8
Partials 105 105
|
I tested on my local machine with this pull request, and it works perfect:
Let us move to code review. |
LGTM |
pouchrobot
added
the
LGTM
one maintainer or community participant agrees to merge the pull reuqest.
label
Apr 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: 程飞 fay.cheng.cn@gmail.com
Ⅰ. Describe what this PR did
make inspect output an array
Ⅱ. Does this pull request fix one issue?
fixes: #1071
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews