feature: add more daemon option in get /info API #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allencloud
force-pushed
the
add-options
branch
2 times, most recently
from
df1ea5c to
242f482
Compare
Codecov Report
@@ Coverage Diff @@
## master #1122 +/- ##
==========================================
+ Coverage 15.89% 15.95% +0.05%
==========================================
Files 172 172
Lines 9563 9528 -35
==========================================
Hits 1520 1520
+ Misses 7933 7898 -35
Partials 110 110
|
Signed-off-by: Allen Sun <allensun.shl@alibaba-inc.com>
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Allen Sun allensun.shl@alibaba-inc.com
Ⅰ. Describe what this PR did
This PR adds more fields in
GET /infoAPI:This PR also adds a system package in pkg which is to fetch system info. Currently, it only fetch os name and memtotal.
Ⅱ. Does this pull request fix one issue?
fixes #1096
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews